Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This has come up in the past, but explicitly today with margret, the notation
dlogX
is unfortunate, in that it is quite definitely wrong. In the spirit oflogL
, it should really belogdX
since it is the log of small volume shell dX. This makes expressions make a little more sense.This is a breaking change (albeit a minor one -- very few users will be using this underlying code), so it should be merged before 2.0.0 release. I have added a helpful error to the old notation.
Checklist:
flake8 anesthetic tests
)pydocstyle --convention=numpy anesthetic
)python -m pytest
)